Skip to content

Skip TestCreateSimulatedEffectivePom only when java command not exist#98

Closed
rujche wants to merge 4 commits into
azure-javaee:feature/sjadfrom
rujche:enable-TestCreateSimulatedEffectivePom-in-github-action
Closed

Skip TestCreateSimulatedEffectivePom only when java command not exist#98
rujche wants to merge 4 commits into
azure-javaee:feature/sjadfrom
rujche:enable-TestCreateSimulatedEffectivePom-in-github-action

Conversation

@rujche

@rujche rujche commented Dec 27, 2024

Copy link
Copy Markdown
  • Skip TestCreateSimulatedEffectivePom only when java command not exist.
  • Add "-v" when run "go test".

@rujche
rujche requested a review from Copilot December 27, 2024 09:44

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment thread cli/azd/internal/appdetect/pom_test.go Outdated
} else {
path, _ := exec.LookPath("java")
slog.Info("Java command found.", "path", path)
}

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rujche

rujche commented Dec 27, 2024

Copy link
Copy Markdown
Author

Closing current PR, because related change has been contained in this PR: #99

@rujche rujche closed this Dec 27, 2024
@rujche
rujche deleted the enable-TestCreateSimulatedEffectivePom-in-github-action branch December 27, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants